Re: [PATCH v1] HID: wacom: #include <linux/device-id/hid.h> instead of <linux/mod_devicetable.h>
From: Ping Cheng
Date: Fri Sep 11 2026 - 15:57:56 EST
On Mon, Jul 6, 2026 at 4:39 AM Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
>
> The single device-id structure that is used by drivers/hid/wacom.h and
> its users (drivers/hid/wacom_sys.c + drivers/hid/wacom_wac.c) is struct
> hid_device_id. So #include the much more lightweight
> <linux/device-id/hid.h> instead the full <linux/mod_devicetable.h>.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Hello,
>
> there is no coordination needed, just make sure to apply it to v7.2-rc2 or
> later. So please take it via the hid tree for the next merge window.
What's the status of this patch? I don't see it merged into 7.2 or 7.3-rc.
The patch works,
Ping
> Best regards
> Uwe
>
> drivers/hid/wacom.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom.h b/drivers/hid/wacom.h
> index 1deacb4568cb..d2398b1cdbb2 100644
> --- a/drivers/hid/wacom.h
> +++ b/drivers/hid/wacom.h
> @@ -82,7 +82,7 @@
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/module.h>
> -#include <linux/mod_devicetable.h>
> +#include <linux/device-id/hid.h>
> #include <linux/hid.h>
> #include <linux/kfifo.h>
> #include <linux/leds.h>
>
> base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
> --
> 2.55.0.11.g153666a7d9bb
>
>