Re: [PATCH 2/8] soundwire: amd: cache ping slave status to avoid spurious disconnect on timeout
From: Mukunda,Vijendar
Date: Mon Sep 14 2026 - 01:32:28 EST
On 9/14/26 01:29, Pierre-Louis Bossart wrote:
On 9/10/26 21:00, Vijendar Mukunda wrote:Thanks, that's a good point.
+ * @ping_slave_stat: cached slave status from the last successful ping response;It'd be good to clarify the definition of a 'successful ping response',
since this concept doesn't exist in the SoundWire spec.
The only valid combined responses are Command_Aborted or Command_Ignored...
The intent here is not to introduce a new SoundWire protocol concept,
but simply to cache the slave_stat field from the last ping transaction
that completed without a command timeout. The cached value is only used
as a fallback when a later ping transaction times out, to avoid
treating a transient transport timeout as "no peripherals attached".
I'll update the comment to avoid the term "successful ping response"
and instead describe it as the slave_stat value from the last ping
transaction that returned a response.