Re: [PATCH net-next 06/10] netlink: specs: ethtool: re-align c33-pse-ext-state

[Kory Maincent]

On 9/11/26 23:41, Asbjørn Sloth Tønnesen wrote:
> enum ethtool_c33_pse_ext_state is mis-aligned with YNL:
>
> - ETHTOOL_C33_PSE_EXT_STATE_OVLD_DETECTED is 6.
> - ETHTOOL_C33_PSE_EXT_STATE_PD_DLL_POWER_TYPE is 7 (not in YNL).
> - ETHTOOL_C33_PSE_EXT_STATE_POWER_NOT_AVAILABLE is 8, not 7.
> - ETHTOOL_C33_PSE_EXT_STATE_SHORT_DETECTED is 9, not 8.
>
> In commit c8149739af86 ("netlink: specs: Expand the PSE netlink command
> with C33 new features") the PD_DLL_POWER_TYPE enum member was skipped,
> leading incorrect values for power-not-available and short-detected.
>
> As PD_DLL_POWER_TYPE is not used, then skip it, but set the value for
> power-not-available to 8.

Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>

Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com