Re: [PATCH 00/31] Add domain idle state names

[Konrad Dybcio]

On 9/14/26 8:59 AM, Maulik Shah wrote:
> Add or update idle-state-name properties for Qualcomm CPU and domain idle
> states.
> 
> The generic cpuidle parser can fall back to the DT node name for CPU idle
> state descriptions, but genpd domain idle states do not get an implicit
> fallback name. Without an idle-state-name property, those genpd states are
> shown as N/A in debugfs.
> 
> For example, before this change a platform may show:
> 
>   # cat /sys/kernel/debug/pm_genpd/power-domain-cluster/idle_states_desc
>   State  Latency(us)  Residency(us)  Name
>   S0     5790         6118           N/A
> 
> With an idle-state-name property in DT, the same state is reported with a
> proper low power mode name:
> 
>   # cat /sys/kernel/debug/pm_genpd/power-domain-cluster/idle_states_desc
>   State  Latency(us)  Residency(us)  Name
>   S0     5800         6118           l3-pc

I left a r-b on most patches, but I have some comments that you may
take into account (and still retain them)

> Describe the affected low power modes explicitly so the CPU and domain idle
> states are reported consistently across Qualcomm platforms. Shorten
> existing power-collapse and power-down names to use pc.

This seems mildly useful.. I know that PC stands for Power Collapse,
but for most other people that's Program Counter or Personal Computer..

And the llcc-off (or l2-xxx) states should be more descriptive to say
what other implications entering this state has (the name does not
make that obvious in isolation)

Konrad