Re: [PATCH v2 0/2] Unify repeated register definitions and move FWCORE macros

[Alessio Belle]

On Mon, 2026-08-10 at 11:35 +0300, Alexandru Dadu wrote:
> Refactor repeated register definitions into base/offset pair.
> Move FWCORE_* macros to pvr_rogue_cr_defs.h.
> 
> Signed-off-by: Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>

For the series,

Reviewed-by: Alessio Belle <alessio.belle@xxxxxxxxxx>

Thanks,
Alessio

> ---
> Changes in v2:
> - Commit description update for the 2nd commit of the series. 
> - Link to v1: https://patch.msgid.link/20260807-b4-unify-repeated-reg-defs-and-move-fwcore-macros-v1-0-375208fbb579@xxxxxxxxxx
> 
> ---
> Matt Coster (2):
>       drm/imagination: Unify repeated register defines
>       drm/imagination: Move FWCORE_* macros to register defines
> 
>  drivers/gpu/drm/imagination/pvr_fw_riscv.c      |  28 +-
>  drivers/gpu/drm/imagination/pvr_fw_startstop.c  |  24 +-
>  drivers/gpu/drm/imagination/pvr_rogue_cr_defs.h | 920 ++++--------------------
>  drivers/gpu/drm/imagination/pvr_rogue_defs.h    |  22 +-
>  drivers/gpu/drm/imagination/pvr_rogue_riscv.h   |   2 -
>  5 files changed, 155 insertions(+), 841 deletions(-)
> ---
> base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
> change-id: 20260806-b4-unify-repeated-reg-defs-and-move-fwcore-macros-737f00de8bf6
> 
> Best regards,
> --  
> Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
>