Re: [PATCH 2/2] drm/imagination: Avoid initialisation of unused FW trace buffer pointer

[Luigi Santivetti]

On Thu, 2026-09-10 at 10:56 +0300, Alexandru Dadu wrote:
> From: Alessio Belle <alessio.belle@xxxxxxxxxx>
> 
> This pointer, which is part of struct rogue_fwif_tracebuf_space (a FW
> interface structure), was initialised but never used to access the FW
> trace buffer - only the source pointer in the initialisation being
> removed is used.
> 
> Signed-off-by: Alessio Belle <alessio.belle@xxxxxxxxxx>
> Signed-off-by: Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
> ---

Reviewed-by: Luigi Santivetti <luigi.santivetti@xxxxxxxxxx>

>  drivers/gpu/drm/imagination/pvr_fw_trace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c
> b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> index 6bb5baa6c41b..813b7b0c8d4e 100644
> --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
> +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> @@ -101,7 +101,6 @@ tracebuf_ctrl_init(void *cpu_ptr, void *priv)
>  		pvr_fw_object_get_fw_addr(trace_buffer->buf_obj,
>  					  &tracebuf_space-
> >trace_buffer_fw_addr);
>  
> -		tracebuf_space->trace_buffer = trace_buffer->buf;
>  		tracebuf_space->trace_pointer = 0;
>  	}
>  }
>