Re: [PATCH] phy: samsung: usbdrd: propagate GS101 PIPE3 lock failures
From: André Draszik
Date: Mon Sep 14 2026 - 14:00:38 EST
On Tue, 2026-06-23 at 21:53 +0800, Pengpeng Hou wrote:
> The GS101 PIPE3 initialization checks the PMA PLL lock and then checks
> the CDR lock. The PLL helper returns an error, but the GS101 PIPE3 init
> path dropped that result. The CDR helper only logged a timeout. PHY
> initialization could therefore still return success after either the PLL
> or the selected receive lane had not locked.
>
> Make the in-file SoC-specific phy_init hook return an int so helpers
> with real failure results can propagate them through the existing PHY
> init paths. Keep the register-only helpers returning success and use the
> new return path to report the GS101 CDR wait failure. Other SoC helper
> paths keep their previous success behavior.
>
> Fixes: 32267c29bc7d ("phy: exynos5-usbdrd: support Exynos USBDRD 3.1 combo phy (HS & SS)")
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 78 ++++++++++++++++-------
> 1 file changed, 55 insertions(+), 23 deletions(-)
Reviewed-by: André Draszik <andre.draszik@xxxxxxxxxx>