Re: [PATCH 1/8] perf test: Skip data_type_profiling when the PMU cannot record memory events

[Arnaldo Carvalho de Melo]

On Sun, Sep 13, 2026 at 06:31:08PM -0700, Namhyung Kim wrote:
> On Sun, Sep 13, 2026 at 07:28:13PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > 
> > The test records with 'perf mem record' in per-thread mode and its only
> > guard matches one specific message:
> > 
> >   perf mem record -o /dev/null -- true 2>&1 | \
> >         grep -q "failed: no PMU supports the memory events" && exit 2
> > 
> > A PMU that has memory events but refuses them per-thread falls through
> > it, and AMD IBS does:
> > 
> >   $ perf mem record -o /dev/null -- true
> >   Error:
> >   Failure to open event 'ibs_op/ldlat=0/u' on PMU 'ibs_op' which will be removed.
> >   Invalid event (ibs_op/ldlat=0/u) in per-thread mode, enable system wide with '-a'.
> >   Error:
> >   Failure to open any events for recording.
> 
> Maybe we need to add a fallback logic to add 'swfilt' term for ibs_op.

Patch 9 in the latest series uses it, take a look.

- Arnaldo
 
> > What follows is not a skip either.  The script runs under 'set -e', so
> > the bare 'perf mem record' in test_basic_annotate() aborts it through the
> > EXIT trap, which reports a signal that never happened and exits 1:
> > 
> >   Basic Rust perf annotate test
> >   Unexpected signal in test_basic_annotate
> > 
> > so 'perf test' turns "this PMU cannot record these events" into a test
> > failure:
> > 
> >   $ perf test "data type profiling"
> >    87: perf data type profiling tests             : FAILED!
> > 
> > Assisted-by: LLM
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> 
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> 
> Thanks,
> Namhyung
> 
> > ---
> >  tools/perf/tests/shell/data_type_profiling.sh | 46 +++++++++++++++----
> >  1 file changed, 36 insertions(+), 10 deletions(-)
> > 
> > diff --git a/tools/perf/tests/shell/data_type_profiling.sh b/tools/perf/tests/shell/data_type_profiling.sh
> > index eca694600a0478d2..a916c410274aa888 100755
> > --- a/tools/perf/tests/shell/data_type_profiling.sh
> > +++ b/tools/perf/tests/shell/data_type_profiling.sh
> > @@ -19,6 +19,15 @@ perfout=$(mktemp /tmp/__perf_test.perf.out.XXXXX)
> >  perf mem record -o /dev/null -- true  2>&1 | \
> >    		grep -q "failed: no PMU supports the memory events" && exit 2
> >  
> > +# Skip if per-thread mem record is not supported on this PMU (e.g. AMD IBS
> > +# needs system-wide '-a'): it is what the test records with below, and a
> > +# failing record must not be reported as a test failure.
> > +if ! perf mem record -o /dev/null -- true 2>/dev/null
> > +then
> > +  echo "Skip: cannot record memory events on this PMU"
> > +  exit 2
> > +fi
> > +
> >  cleanup() {
> >    rm -rf "${perfdata}" "${perfout}"
> >    rm -rf "${perfdata}".old
> > @@ -52,25 +61,42 @@ test_basic_annotate() {
> >      index=1 ;;
> >    esac
> >  
> > +  # Under 'set -e' a bare failing command aborts the script through the EXIT
> > +  # trap, so the commands that report a failure have to be the condition of
> > +  # an 'if' for that reporting to ever happen.
> >    if [ "x${mode}" == "xBasic" ]
> >    then
> > -    perf mem record -o "${perfdata}" ${testprogs[$index]} 2> /dev/null
> > +    if ! perf mem record -o "${perfdata}" ${testprogs[$index]} 2> /dev/null
> > +    then
> > +      echo "${mode} annotate [Failed: perf record]"
> > +      err=1
> > +      return
> > +    fi
> >    else
> > -    perf mem record -o - ${testprogs[$index]} 2> /dev/null > "${perfdata}"
> > -  fi
> > -  if [ "x$?" != "x0" ]
> > -  then
> > -    echo "${mode} annotate [Failed: perf record]"
> > -    err=1
> > -    return
> > +    if ! perf mem record -o - ${testprogs[$index]} 2> /dev/null > "${perfdata}"
> > +    then
> > +      echo "${mode} annotate [Failed: perf record]"
> > +      err=1
> > +      return
> > +    fi
> >    fi
> >  
> >    # Generate the annotated output file
> >    if [ "x${mode}" == "xBasic" ]
> >    then
> > -    perf annotate --code-with-type -i "${perfdata}" --stdio --percent-limit 1 2> /dev/null > "${perfout}"
> > +    if ! perf annotate --code-with-type -i "${perfdata}" --stdio --percent-limit 1 2> /dev/null > "${perfout}"
> > +    then
> > +      echo "${mode} annotate [Failed: perf annotate]"
> > +      err=1
> > +      return
> > +    fi
> >    else
> > -    perf annotate --code-with-type -i - --stdio 2> /dev/null --percent-limit 1 < "${perfdata}" > "${perfout}"
> > +    if ! perf annotate --code-with-type -i - --stdio 2> /dev/null --percent-limit 1 < "${perfdata}" > "${perfout}"
> > +    then
> > +      echo "${mode} annotate [Failed: perf annotate]"
> > +      err=1
> > +      return
> > +    fi
> >    fi
> >  
> >    # check if it has the target data type
> > -- 
> > 2.55.0
> >