Re: [RFC PATCH 8/8] mm/damon/core-kunit: test invalid damos filter commits

From: SJ Park

Date: Mon Sep 14 2026 - 19:50:33 EST


Hi Kunwu,

On Mon, 14 Sep 2026 23:57:27 +0800 Kunwu Chan <kunwu.chan@xxxxxxxxx> wrote:

> On Sat, 12 Sep 2026 12:18:06 -0700 SJ Park <sj@xxxxxxxxxx> wrote:
>
> > Add test cases for testing the validation of damos filter arguments in
> > commit time.
[...]
> Could we also test an invalid PROBE_HITS_WSUM range here?
>
> Patch 4 adds the same max < min validation for
> DAMOS_FILTER_TYPE_PROBE_HITS_WSUM, but this test only covers
> ADDR and HUGEPAGE_SIZE.

I agree it is better to add a test. But not necessarily together with this
series, in my humble opinion. I am separately working on the test.


Thanks,
SJ

[...]