Re: [PATCH v4 1/2] powerpc/bug: Add ARCH_WARN_ASM and refactor _EMIT_BUG_ENTRY for Rust support

From: Mukesh Kumar Chaurasiya

Date: Tue Sep 15 2026 - 02:20:44 EST


[...]
> From the current implementation it looks like making "1b" a parameter doesn't
> really help anything. The fact that it internally rely on `2:` as label is still
> hardcoded.
>
> I think you should either make the label custom too, so you write
>
> "1: twi 31, 0, 0\n" \
> _EMIT_BUG_ENTRY(2, 1b, file, line, flags) \
> ".org 2b+" size "\n" \
>
> Or you should just hardcode "2" and "1b" and document them.
>
> This stucks in mid-way and is arguably worse than either option.
>
> Best,
> Gary
>
Hey Gary,

Yeah makes sense. Lemme refactor this with labels as an argument and
test it out. Thanks.

Regards,
Mukesh
[...]