Re: [PATCH v2 3/7] arm64: dts: freescale: Add Lino iMX93

[Andrew Lunn]

On Tue, Sep 15, 2026 at 03:28:06PM +0200, Francesco Dolcini wrote:
> Hello Andrew,
> thanks for the review.
> 
> On Tue, Sep 15, 2026 at 03:19:45PM +0200, Andrew Lunn wrote:
> > > +	ethphy1: ethernet-phy@1 {
> > > +		reg = <1>;
> > > +		interrupt-parent = <&adapter_gpio_expander>;
> > > +		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> > 
> > Falling interrupts is probably wrong. They are normally level, active
> > low.
> 
> 
> It is wanted. The I2C ioexpander component used for the interrupt
> supports only edge interrupts. We tested it and it works fine like that.

It works, until it does not work, because you hit a race condition
with the hardware, two interrupts in quick succession. The second one
gets lost, and your link remains down forever.

>  - when we tested it, the SW emulation was not really reliable, and we
>    prefer to play on the safe side

If you want to be safe, delete the interrupt properties and let phylib
poll the PHY. That always works.

     Andrew