Re: [PATCH v2] checkkconfigsymbols: resolve revisions before resetting the tree

[Nathan Chancellor]

On Tue, Sep 15, 2026 at 12:43:29PM +0100, Julian Braha wrote:
> On 9/7/26 11:37, Erkan Erdem wrote:
> > The same problem affects --commit with the current branch name.
> > 
> > Fixes: b1a3f243485f ("checkkconfigsymbols.py: make it Git aware")
> 
> While it's good to support this, I don't think the Fixes tag is
> appropriate here, because this wasn't really a bug... it was just
> unsupported functionality.

I guess it is because neither this change nor the below change did not
take care of disallowing the branch name with '--commit'. That said, I
do agree that I think a Fixes is a little superfluous here, I would
leave it off of future revisions.

> > Link: https://lore.kernel.org/20210901145212.478066-1-arielmarcovitch@xxxxxxxxx/
> 
> This commit added a check that will cause the script to exit if
> 'HEAD...' is passed to --commit. So it seems like this patch should also
> remove those lines now.

While I do agree that we should revert this change, which is

  d62d5aed3354 ("checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit")

in the tree, I think it would be better done as a separate commit, whose
justification is that HEAD is now properly resolved as a result of this
change.

-- 
Cheers,
Nathan