Re: [PATCH net-next v3] selftests: drv-net: add BIG TCP test cases

[Narcisa Vasile]

On Mon, Sep 14, 2026 at 05:26:37AM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider:
> 
> Critical: 0 · High: 0 · Medium: 1 (1) · Low: 1
> 
> - [Medium] The four new `big_tcp_*` variants are yielded by
>   `_gro_variants()` in tools/testing/selftests/drivers/net/gro_lib.py…
> - [Low] The patch changes the failure-tolerance policy in `run_test()`
>   from `test_name.startswith("large_")` to…
> 
The tests can still be run for all 3 variants and the MTU setup is
useful for all modes. The commit seems clear enough.

> Pre-existing issues:
> - [Medium] `check_recv_pkts()` (tools/testing/selftests/net/lib/gro.c)
>   reads `correct_payload[num_pkt]` once per received non-FIN frame with…

This is a valid pre-existing issue. I've sent a separate patch to net
with the fix, according to the guidance on fixes. That patch doesn't
conflict with this one.

> -- 
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260913052419.77910-1-narcisav.kernel%40gmail.com