Re: [PATCH v1 1/1] resource: Replace open coded resource_overlaps()

From: Andy Shevchenko

Date: Wed Sep 16 2026 - 03:17:48 EST


On Tue, Sep 15, 2026 at 07:25:33PM +0100, Bradley Morgan wrote:
> On 15 September 2026 09:53:53 BST, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> >+ pr_debug("resource sanity check: requesting %pR, which spans more than %s %pR\n",
> >+ &mem, p->name, p);
>
> This swap is not mentioned in the changelog and it does change the
> output a bit: %pa prints 0x1000, %pR pads the numbers to 10 hex digits,
> so the debug line gains a bunch of zeros. Debug only, so I don't care
> much, but a line in the changelog saying the print changed with it
> would be good?

Sure, Will do in v2.

> Other than that, LGTM
>
> Reviewed-by: Bradley Morgan <brads@xxxxxxxxxxxxxx>

Thanks!

--
With Best Regards,
Andy Shevchenko