Re: [PATCH net-next v2 1/2] dt-bindings: net: allwinner: add H616 EMAC1

[Andre Przywara]

Hi,

On 9/16/26 05:07, James Hilliard wrote:
> The H616 secondary EMAC uses a separate system-control clock register
> and supports only RMII at 10/100 Mbps. Add its distinct compatible
> without an older fallback, since using the primary EMAC clock register
> would not work.
>
> Constrain the PHY interface mode to RMII, matching the hardware.
>
> Signed-off-by: Richard Genoud <richard.genoud@xxxxxxxxxxx>

Where does this come from? If Richard is the author, then please reflect 
this in the patch (git commit --amend --author ...), so a From: line 
appears in the body of the email.
If not, it's unclear why this line is here.

The actual patch looks good to me:

Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

Cheers,
Andre

> Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx>
> ---
>   .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml  | 13 +++++++++++++
>   Documentation/devicetree/bindings/net/snps,dwmac.yaml       |  2 ++
>   2 files changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> index 323a669fa982..2cae0133b3cd 100644
> --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> @@ -21,6 +21,7 @@ select:
>             - allwinner,sun8i-r40-gmac
>             - allwinner,sun8i-v3s-emac
>             - allwinner,sun50i-a64-emac
> +          - allwinner,sun50i-h616-emac1
>             - allwinner,sun55i-a523-gmac200
>     required:
>       - compatible
> @@ -33,6 +34,7 @@ properties:
>         - const: allwinner,sun8i-r40-gmac
>         - const: allwinner,sun8i-v3s-emac
>         - const: allwinner,sun50i-a64-emac
> +      - const: allwinner,sun50i-h616-emac1
>         - items:
>             - enum:
>                 - allwinner,sun20i-d1-emac
> @@ -91,6 +93,17 @@ required:
>   
>   allOf:
>     - $ref: snps,dwmac.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: allwinner,sun50i-h616-emac1
> +
> +    then:
> +      properties:
> +        phy-mode:
> +          const: rmii
> +
>     - if:
>         properties:
>           compatible:
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2ed4564ae99d..b20149c3e850 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -57,6 +57,7 @@ properties:
>           - allwinner,sun8i-r40-gmac
>           - allwinner,sun8i-v3s-emac
>           - allwinner,sun50i-a64-emac
> +        - allwinner,sun50i-h616-emac1
>           - amlogic,meson6-dwmac
>           - amlogic,meson8b-dwmac
>           - amlogic,meson8m2-dwmac
> @@ -623,6 +624,7 @@ allOf:
>                   - allwinner,sun8i-r40-gmac
>                   - allwinner,sun8i-v3s-emac
>                   - allwinner,sun50i-a64-emac
> +                - allwinner,sun50i-h616-emac1
>                   - loongson,ls2k-dwmac
>                   - loongson,ls7a-dwmac
>                   - ingenic,jz4775-mac