Re: [PATCH v3 2/2] drm/imx: replace struct drm_simple_display_pipe with regular atomic helpers

[Thomas Zimmermann]

Hi

Am 16.09.26 um 09:46 schrieb Maxime Ripard:
> On Wed, Sep 16, 2026 at 08:50:21AM +0200, Thomas Zimmermann wrote:
> > > +static const struct drm_plane_funcs imx_lcdc_plane_funcs = {
> > > +	.update_plane		= drm_atomic_helper_update_plane,
> > > +	.disable_plane		= drm_atomic_helper_disable_plane,
> > > +	.destroy		= drm_plane_cleanup,
> > > +	.reset			= drm_atomic_helper_plane_reset,
> Also, this needs to be drm_atomic_helper_plane_create_state
>
> > > +static const struct drm_crtc_funcs imx_lcdc_crtc_funcs = {
> > > +	.reset			= drm_atomic_helper_crtc_reset,
>   and drm_atomic_helper_crtc_create_state

Right. I forgot that create_state is available already.

Best regards
Thomas

> Maxime

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)