Re: [PATCH 2/6] usb: xhci-mtk: add missing pm_runtime_dont_use_autosuspend() call
From: Johan Hovold
Date: Wed Sep 16 2026 - 04:23:07 EST
On Tue, Sep 15, 2026 at 09:02:19AM +0000, Joshua Crofts wrote:
> The disable_pm label in xhci_mtk_probe() and xhci_mtk_remove() both call
> pm_runtime_disable() on error or device teardown, but don't call
> pm_runtime_dont_use_autosuspend(), causing resource leaks.
No, there is no resource leak here either and this does not need to be
backported.
The autosuspend setting is not restored, but that would only possibly
have an impact in the theoretical corner case that someone forcibly
rebinds a different driver that does not enable it.
> Add the missing pm_runtime_dont_use_autosuspend().
>
> Found using Coccinelle.
>
> Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")
> Fixes: 04284eb74e0c ("usb: xhci-mtk: add support runtime PM")
> Cc: <stable@xxxxxxxxxxxxxxx>
So, without having looked at the rest: none of these should be
backported.
Johan