Re: [PATCH 1/4] dt-bindings: arm: qcom: add Lenovo ThinkPad T14s Gen 7 (Mahua)

[Krzysztof Kozlowski]

On Tue, Sep 15, 2026 at 02:41:19PM +0100, Srinivas Kandagatla wrote:
> On 9/15/26 11:47 AM, Krzysztof Kozlowski wrote:
> > On Sun, Sep 13, 2026 at 09:18:32PM +0100, Srinivas Kandagatla wrote:
> >> Add lenovo,thinkpad-t14s-gen7 as a board compatible under qcom,mahua.
> >> The T14s Gen 7 uses the Mahua SoC (a 12-core variant of Glymur with
> >> cluster2 / cpu12-cpu17 fused off) rather than Glymur proper, matching
> >> what the platform's ACPI MADT dump reports (12 enabled + 6 disabled
> >> processors).
> > 
> > There is variant with X2E and X2P processors, and on top of that touch
> > and non-touch display. The first will be differentiated by SoC
> > compatible but don't you need compatibles for the last part - display?
> 
> I only have the LCD variant in front of me
> We could follow the Gen 6 T14s pattern (which already has the LCD/OLED
> split upstream) and two variant SoCs for v2:
> how about something like this?
> 
>   - items:
>       - enum:
>           - lenovo,thinkpad-t14s-gen7-lcd
>           - lenovo,thinkpad-t14s-gen7-oled
>       - const: lenovo,thinkpad-t14s-gen7

Yes, assuming the hardware has actual relevant differences between LCD
and OLED.

Best regards,
Krzysztof