Re: [PATCH] tee: move tee_ioctl_shm_register_data to above IOCTL definition

From: Jens Wiklander

Date: Wed Sep 16 2026 - 04:51:39 EST


On Fri, Sep 11, 2026 at 9:40 AM Sumit Garg via OP-TEE
<op-tee@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 03 Sep 2026 at 12:57:30 -0500, Andrew Davis via OP-TEE wrote:
> >Most of the struct definitions for a given IOCTL definition immediately
> >preceded that definition. The struct tee_ioctl_shm_register_data is an
> >exception as it is placed above the TEE_IOC_SHM_REGISTER_FD definition,
> >not the TEE_IOC_SHM_REGISTER one it is to be used with. Move it down
> >to match the others.
> >
> >This is a non-functional change for consistency and to help prevent
> >someone from accidentally using the wrong struct with the wrong IOCTL
> >based on the struct's location.
> >
> >Fix a couple small spelling issues while here.
> >
> >Signed-off-by: Andrew Davis <afd@xxxxxx>
> >---
> > include/uapi/linux/tee.h | 40 ++++++++++++++++++++--------------------
> > 1 file changed, 20 insertions(+), 20 deletions(-)
> >
>
> Reviewed-by: Sumit Garg <sumit.garg@xxxxxxxxxxxxxxxx>

I'm picking this up.

Thanks,
Jens