Re: [PATCH v3 7/8] iio: imu: inv_icm42607: Add accelerometer calibbias support

From: Joshua Crofts

Date: Wed Sep 16 2026 - 05:45:26 EST


On Wed, 16 Sep 2026 09:37:32 +0000
Kanak Shilledar <Kanak.Shilledar@xxxxxxxx> wrote:

> Hi Jonathan,
>
> On Mon, 2026-09-07 at 02:54 +0100, Jonathan Cameron wrote:
> > > Expose IIO_CHAN_INFO_CALIBBIAS on the accelerometer channels. The
> > > registers are stored in MREG1, which can be accessed by the
> > > mreg_read
> > > and mreg_write routines. The calibration bias is written to
> > > OFFSET_USER4
> > > to OFFSET_USER8 registers in MREG1.
> > >
> > > Note: The accelerometer functionality is tested with Invensense,
> > > ICM42370-P development board.
> > >
> > > Datasheet:
> > > https://www.invensense.tdk.com/en-us/products/3-axis/icm-42370-p
> > > Datasheet: https://www.lcsc.com/product-detail/C5129967.html
> > > Signed-off-by: Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> >
> > Various things inline.
> >
> > Thanks
> >
> > Jonathan
>
> I will fix these issues.
> Thanks and Regards,
> Kanak Shilledar
>

Hi Kanak,

No need to send a response to a review only saying you'll fix the
pointed out issues, it generates too much noise on the list. No
response means you agree with the review and will address it in
the next version :)

Thanks!

--
Kind regards,
Joshua Crofts