Re: [PATCH v3 3/4] virt: tdx-guest: Use a variable to store the Quote buffer size

From: Peter Fang

Date: Wed Sep 16 2026 - 05:45:32 EST


On Wed, Sep 02, 2026 at 04:15:05PM -0700, Peter Fang wrote:
> >
> > > constant with a variable.
> > >
> > > The size is currently a constant sprinkled across several places. Store
> > > it in a variable and have all the users read it from there.
> >
> > You are also dropping PAGE_ALIGN() in alloc and free calls. You can
> > mention it in commit log.
>
> Good catch. I will add this next time.

I ended up not dropping PAGE_ALIGN() in v4 [1]. To be more precise
PAGE_ALIGN() got moved out of the alloc and free calls, but was kept
when initializing quote_data_len. So this didn't make it into the commit
log.

[1] https://lore.kernel.org/all/20260915092632.2822169-4-peter.fang@xxxxxxxxx/

>