Re: [PATCH] coresight: handle runtime PM resume failures

[Leo Yan]

On Fri, Sep 11, 2026 at 03:28:52AM -0700, Yuanfang Zhang wrote:

[...]

> Replace the remaining pm_runtime_get_sync() calls with
> pm_runtime_resume_and_get(), which restores the runtime PM usage count
> when resume fails. Abort before accessing hardware and propagate the
> error to the caller.

The change makes sense to me.

> In coresight_get_ref(), unwind the module and device references.

Sashiko reported a pre-existing issue where the callers don't handle
errors returned by coresight_get_ref() [1]. In this case, we need to
remove nodes from path->path_list and release them. However, this
should be done in a separate patch.

[1] https://sashiko.dev/#/patchset/20260911-b4-coresight-runtime-pm-failures-v1-1-acdf49756e11%40qti.qualcomm.com

> Signed-off-by: Yuanfang Zhang <yuanfang.zhang@xxxxxxxxxxxxxxxx>

Thanks for the fix! Feel free to add:

Reviewed-by: Leo Yan <leo.yan@xxxxxxx>