[PATCH 37/48] clk: qcom: gpucc-sc7280: Use common probe handling for always-on clocks

From: Abel Vesa

Date: Wed Sep 16 2026 - 06:46:11 EST


Describe the always-on branches in a critical_cbcrs array and reference
it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these
branches instead of programming them directly in the driver's probe.

Move the GMU branch register update into the clk_regs_configure callback
so it still follows the always-on branch enables.

Assisted-by: LLM
Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
---
drivers/clk/qcom/gpucc-sc7280.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c
index bd699a624517..9b267276eac7 100644
--- a/drivers/clk/qcom/gpucc-sc7280.c
+++ b/drivers/clk/qcom/gpucc-sc7280.c
@@ -440,7 +440,24 @@ static const struct regmap_config gpu_cc_sc7280_regmap_config = {
.fast_io = true,
};

+static const u32 gpu_cc_sc7280_critical_cbcrs[] = {
+ 0x1170, /* GPU_CC_CB_CLK */
+ 0x1098, /* GPUCC_CX_GMU_CLK */
+};
+
+static void gpu_cc_sc7280_regs_configure(struct device *dev, struct regmap *regmap)
+{
+ regmap_update_bits(regmap, 0x1098, BIT(13), BIT(13));
+}
+
+static const struct qcom_cc_driver_data gpu_cc_sc7280_driver_data = {
+ .clk_cbcrs = gpu_cc_sc7280_critical_cbcrs,
+ .num_clk_cbcrs = ARRAY_SIZE(gpu_cc_sc7280_critical_cbcrs),
+ .clk_regs_configure = gpu_cc_sc7280_regs_configure,
+};
+
static const struct qcom_cc_desc gpu_cc_sc7280_desc = {
+ .driver_data = &gpu_cc_sc7280_driver_data,
.config = &gpu_cc_sc7280_regmap_config,
.clks = gpu_cc_sc7280_clocks,
.num_clks = ARRAY_SIZE(gpu_cc_sc7280_clocks),
@@ -464,11 +481,6 @@ static int gpu_cc_sc7280_probe(struct platform_device *pdev)

clk_lucid_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config);

- /* Keep some clocks always-on */
- qcom_branch_set_clk_en(regmap, 0x1170); /* GPU_CC_CB_CLK */
- qcom_branch_set_clk_en(regmap, 0x1098); /* GPUCC_CX_GMU_CLK */
- regmap_update_bits(regmap, 0x1098, BIT(13), BIT(13));
-
return qcom_cc_really_probe(&pdev->dev, &gpu_cc_sc7280_desc, regmap);
}


--
2.54.0