Re: [PATCH v2 11/13] s390/qdio_setup: Use kzalloc() for the storage list

[Heiko Carstens]

On Wed, Sep 16, 2026 at 01:23:23PM +0300, Mike Rapoport wrote:
> On Wed, Sep 16, 2026 at 11:27:20AM +0200, Heiko Carstens wrote:
> > On Thu, Sep 10, 2026 at 02:00:13PM +0300, Mike Rapoport (Microsoft) wrote:
> > > __qdio_allocate_qs() allocates the storage list information block of a
> > > queue.
> > > 
> > > This memory can be allocated with kmalloc() as there's nothing special
> > > about it to go directly to the page allocator.
> > ...
> > > @@ -109,7 +109,7 @@ static int __qdio_allocate_qs(struct qdio_q **irq_ptr_qs, int nr_queues)
> > >  			return -ENOMEM;
> > >  		}
> > >  
> > > -		q->sl_page = (void *)__get_free_page(GFP_KERNEL);
> > > +		q->sl_page = kzalloc(PAGE_SIZE, GFP_KERNEL);
> > >  		if (!q->sl_page) {
> > 
> > Speaking about unnecessary changes: why is this a conversion to
> > kzalloc() instead of kmalloc()?
> 
> An LLM went wild and I missed it in my review :)
> Same in another patch.

I guess we want a v3 then, even if this is trivial.