Re: [PATCH 03/20] ASoC: samsung: snow: Fix clock leak in snow_probe()

From: Mark Brown

Date: Wed Sep 16 2026 - 08:04:22 EST


On Wed, Sep 16, 2026 at 07:03:41AM +0000, Wentao Liang wrote:
> In snow_probe(), priv->clk_i2s_bus is acquired via of_clk_get_by_name().
> If devm_snd_soc_register_card() subsequently fails, the acquired clock
> is never released, leading to a reference count leak.

You've not copied me on the rest of the series so I don't know what's
going on with dependencies. When sending a patch series it is important
to ensure that all the various maintainers understand what the
relationship between the patches as the expecation is that there will be
interdependencies. Either copy everyone on the whole series or at least
copy them on the cover letter and explain what's going on. If there are
no strong interdependencies then it's generally simplest to just send
the patches separately to avoid any possible confusion.

Attachment: signature.asc
Description: PGP signature