Re: [PATCH v2] char: omap-rng: fix runtime PM cleanup

[Herbert Xu]

On Fri, Sep 04, 2026 at 02:26:54PM +0400, Jiawen Liu wrote:
> omap_rng_probe() enables runtime PM before requesting its optional clocks.
> If either devm_clk_get() returns -EPROBE_DEFER, the direct return leaves
> the runtime PM usage count elevated and runtime PM enabled. The second
> clock lookup can also leave the first clock enabled.
> 
> Route each deferred-probe path through resource-matched cleanup. Return
> directly after cleanup so normal probe deferrals remain quiet.
> 
> Fixes: 43ec540e6f9b ("hwrng: omap - move clock related code to omap_rng_probe()")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Jiawen Liu <1298662399@xxxxxx>
> ---
> Changes in v2:
> - Use the full author name in From and Signed-off-by.
> - Return directly after deferred-probe cleanup to keep deferrals quiet.
> - Add Fixes and Cc stable tags.
> 
> v1: https://lore.kernel.org/all/tencent_1DBD00BAFF365506D40F166D40DEE8F63B0A@xxxxxx/
> Sashiko review: https://sashiko.dev/#/patchset/tencent_1DBD00BAFF365506D40F166D40DEE8F63B0A%40qq.com
> 
>  drivers/char/hw_random/omap-rng.c | 22 ++++++++++++++++++----
>  1 file changed, 18 insertions(+), 4 deletions(-)

Sashiko couldn't apply your patch against linux-next:

https://sashiko.dev/#/patchset/tencent_0D4EB3807DBF6095A7F5A9455D902DBA9708%40qq.com

Please rebase and repost.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt