Re: [PATCH] crypto: talitos: request irq after tasklet_init()

[Herbert Xu]

Rosen Penev <rosenp@xxxxxxxxx> wrote:
> The talitos interrupt handlers schedule priv->done_task[] via
> tasklet_schedule().  In probe(), talitos_probe_irq() ran before
> tasklet_init(), so an interrupt arriving during that window (a shared
> IRQ, or a completion pending from an earlier transmission) would
> schedule an uninitialized tasklet.
> 
> Move talitos_probe_irq() after the tasklet_init() calls so the
> tasklets are fully set up before interrupts are enabled.  This matches
> remove(), which frees the IRQs before killing the tasklets.
> 
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
> drivers/crypto/talitos.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Please have a look at

https://sashiko.dev/#/patchset/20260904211230.81963-1-rosenp%40gmail.com

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt