Re: [PATCH net] eth: fbnic: Fix payload page pool error cleanup
From: Simon Horman
Date: Wed Sep 16 2026 - 09:12:24 EST
On Tue, Sep 15, 2026 at 12:49:15PM +0200, Björn Töpel wrote:
> The payload page pool pointer contains an error pointer when its
> allocation fails. The cleanup path passes that error pointer to
> page_pool_destroy() instead of destroying the header page pool. This
> can dereference the error pointer and leave the header page pool
> allocated.
>
> Destroy the header page pool instead.
>
> Fixes: 8a11010fdd96 ("eth: fbnic: allocate unreadable page pool for the payloads")
> Reported-by: Sashiko <netdev-bot+sashiko@xxxxxxxxxx>
> Link: https://lore.kernel.org/netdev/178915061000.219967.7726187707862333281@xxxxxxxxxx/
> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>