Re: [PATCH v2 RESEND 2/2] usb: typec: Add onsemi FUSB15201 driver

[Shawn Guo]

On Mon, Sep 14, 2026 at 03:10:21PM +0200, Heikki Krogerus wrote:
> On Fri, Sep 11, 2026 at 03:34:14PM +0800, Shawn Guo wrote:
> > The FUSB15201 is a dual-port USB Type-C and Power Delivery controller
> > which runs the Type-C state machine and the PD policy engine on an
> > integrated microcontroller. The host only observes the resulting state
> > and may ask for role swaps, so this is a plain Type-C class driver
> > rather than a TCPC driven by the Type-C Port Manager.
> > 
> > Register a Type-C port for each connector described in firmware, report
> > attach and detach, orientation, power and data roles and the PD
> > capability of the partner, and drive the USB role switch of the attached
> > USB controller so that OTG role switching works. Data and power role
> > swaps requested through sysfs are forwarded to the controller, which
> > performs them asynchronously and reports the outcome as a port status
> > interrupt.
> > 
> > The controller exposes a per-port VBUS ADC reading, but the Type-C class
> > has no VBUS attribute and nothing needs the value, so it is not read.
> > PD messages, PDOs and alternate modes are not exposed by the hardware at
> > all. The chip-wide MASTER_RESET command would drop both ports at once
> > and has no caller, so it is left alone as well.
> > 
> > Assisted-by: LLM
> > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> 
> You changed the commit message, and that counts too. This is v3.

The resend only removes a Link tag. I did not know that removal/addition
of tags in commit log counts too.

> A
> few nitpicks below.

I will change those as suggested.

Thanks for reviewing, Heikki!

Shawn