Re: (subset) [PATCH v3 1/2] mfd: wcd934x: Fix NULL pointer dereference on IRQ probe deferral

[Lee Jones]

On Wed, 16 Sep 2026, Lee Jones wrote:

> On Thu, 03 Sep 2026 17:21:42 +0200, David Heidelberg wrote:
> > ddata->dev is only assigned at the end of wcd934x_slim_probe(), but the
> > of_irq_get() error path has passed it to the error print since the
> > driver was added, while it is still NULL.
> > 
> > This used to be harmless with dev_err(), which copes with a NULL device
> > and was skipped on -EPROBE_DEFER. Since the switch to dev_err_probe(), a
> > deferred IRQ reaches device_set_deferred_probe_reason() ->
> > dev_driver_string(), which dereferences the NULL pointer and crashes
> > during probe. Use dev, which is already valid at this point.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] mfd: wcd934x: Fix NULL pointer dereference on IRQ probe deferral
>       commit: 1389a4a5877403e57573d6bc01c5b7790a4472ce

Didn't apply initially, but I reworked it.

-- 
Lee Jones