Re: [PATCH v2 2/3] selftests/mm: mark file-local symbols of pagemap_ioctl.c static
From: David Hildenbrand (Arm)
Date: Wed Sep 16 2026 - 11:52:28 EST
On 9/8/26 15:43, Zenghui Yu wrote:
> From: "Zenghui Yu (Huawei)" <zenghui.yu@xxxxxxxxx>
>
> The file-scope variables (pagemap_fd, uffd, page_size, hpage_size and
> progname) and most functions of the pagemap_ioctl test are only used
> locally, but lack the static storage class. Mark them static so that the
> compiler can catch accidental outer references.
>
> Suggested-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@xxxxxxxxx>
> ---
Thanks!
Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
--
Cheers,
David