Re: [PATCH] ASoC: rt766: fix HID dependency for SND_SOC_SDCA_HID
From: Mark Brown
Date: Wed Sep 16 2026 - 12:41:14 EST
On Wed, Sep 16, 2026 at 05:36:02PM +0200, Arnd Bergmann wrote:
> On Wed, Sep 16, 2026, at 17:10, Mark Brown wrote:
> > On Tue, Sep 15, 2026 at 11:16:34PM +0200, Arnd Bergmann wrote:
> >> depends on SOUNDWIRE
> >> depends on SND_SOC_SDCA
> >> + depends on HID
> > Should that be HID=y || HID=SND_SOC_SDCA like for SND_SOC_SDCA_HID and
> > SND_SOC_SDCA_CLASS? The dependencies on _CLASS should stop the
> > problematic cases from actually occurring but I'm not sure if it stops
> > the warning.
> Yes. Just as I was trying to write up my presentation slides for next
> week trying to explain how nobody ever gets this right, you have reminded
> me that I can't do it either ;-)
> How about this version?
...
> I think this is much clearer than the original version or my
> first patch, as it avoids the fragile 'select'. If you like this
> one, I'll send a v2 after this passes some more randconfig testing,
> or you can apply that directly.
Looks good to me but I'm not entirely confident in my Kconfig special
case knowledge, I'll wait for your new version after testing.
Attachment:
signature.asc
Description: PGP signature