Re: [PATCH v3 13/15] tests: Add wip_func utility

[Herve Codina]

Hi David,

On Wed, 16 Sep 2026 20:00:40 +1000
David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Aug 26, 2026 at 10:31:44AM +0200, Herve Codina wrote:
> > wip_func is a test utility allowing to wrap the write inplace functions.
> > 
> > It allows to create tests with custom wip write sequence.
> > 
> > Also the modified dtb is saved allowing to perform later checks on this
> > modified dtb.  
> 
> It's not clear to me what this is useful for that's not already
> covered by the existing write-in-place tests (nop_node.c,
> nop_property.c and setprop_inplace.c).
> 

Used in tests to check dtb updates when "unknown" tags are involved.
See '[PATCH v3 14/15] libfdt: Handle unknown tags on dtb modifications' [0]
or full source at [1].

Depending on modification performed, "unknown" tags must be removed or not
and the version must be downgrade or not. The test checked for rules defined
for modification when "unknown" tags are involved (see patch 14/15 commit log)

I don't think that this could be covered in a simple way by existing
write-in-place tests.

[0] https://lore.kernel.org/devicetree-compiler/20260826083146.304291-15-herve.codina@xxxxxxxxxxx/
[1] https://github.com/bootlin/dtc/blob/2653bb9cd4414780c863051467b5e77eea6e5bdd/tests/run_tests.sh#L590

Best regards,
Hervé