[PATCH] iio: accel: bma400: Fix trigger reference leak in bma400_probe()
From: Wentao Liang
Date: Wed Sep 16 2026 - 14:00:14 EST
Move indio_dev->trig = iio_trigger_get(data->trig) after the
devm_request_threaded_irq() and triggered buffer setup succeed. If
either fails before INDIO_BUFFER_TRIGGERED is set, the IIO core does
not put the trigger reference in iio_dev_release(), leaking it.
Fixes: ffe0ab6a9698 ("iio: accel: bma400: Add triggered buffer support")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
---
drivers/iio/accel/bma400_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
index 05f72707f830..a5889b67585e 100644
--- a/drivers/iio/accel/bma400_core.c
+++ b/drivers/iio/accel/bma400_core.c
@@ -1783,7 +1783,6 @@ int bma400_probe(struct device *dev, struct regmap *regmap, int irq,
return dev_err_probe(data->dev, ret,
"iio trigger register fail\n");
- indio_dev->trig = iio_trigger_get(data->trig);
ret = devm_request_threaded_irq(dev, irq, NULL,
&bma400_interrupt,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
@@ -1799,6 +1798,9 @@ int bma400_probe(struct device *dev, struct regmap *regmap, int irq,
return dev_err_probe(data->dev, ret,
"iio triggered buffer setup failed\n");
+ if (irq > 0)
+ indio_dev->trig = iio_trigger_get(data->trig);
+
return devm_iio_device_register(dev, indio_dev);
}
EXPORT_SYMBOL_NS(bma400_probe, "IIO_BMA400");
--
2.34.1