Re: [PATCH v12 3/6] mmc: sdhci-msm: Set ICE clk to TURBO at sdhci ICE init

[Abhinaba Rakshit]

On Thu, Sep 10, 2026 at 12:17:46PM +0200, Ulf Hansson wrote:
> On Sun, Aug 23, 2026 at 9:48 PM Abhinaba Rakshit
> <abhinaba.rakshit@xxxxxxxxxxxxxxxx> wrote:
> >
> > MMC controller lacks a clock scaling mechanism, unlike the UFS
> > controller. By default, the MMC controller is set to TURBO mode
> > during probe, but the ICE clock remains at XO frequency,
> > leading to read/write performance degradation on eMMC.
> >
> > To address this, set the ICE clock to TURBO during sdhci_msm_ice_init
> > to align it with the controller clock. This ensures consistent
> > performance and avoids mismatches between the controller
> > and ICE clock frequencies.
> >
> > For platforms where ICE is represented as a separate device,
> > use the OPP framework to vote for TURBO mode, maintaining
> > proper voltage and power domain constraints.
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Reviewed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@xxxxxxxxxxxxxxxx>
> 
> This looks good to me!
> 
> Although I have a question - should we never drop the vote? Like at
> suspend and runtime suspend, at least?

This point is already discussed with Konrad on earlier patchseries:
https://lore.kernel.org/all/d1232243-2f23-423b-84ac-4463eac79f9a@xxxxxxxxxxxxxxxx/

Since, as the device goes to suspend and power will be turned down,
PM runtime will drop the votes and hence having it in suspend resume
is redundent.

Abhinaba Rakshit