Re: [RFC PATCH 0/2] xfs: change xfs log item refcount design

[Dave Chinner]

On Fri, Sep 11, 2026 at 03:55:00PM +0530, Jeffin Philip wrote:
> This patch series is the first of the series where we attempt to convert
> the XFS Log item reference counting design to be more generic
> compared to the previous type-specific state to fix the "zero
> refcount but in AIL means alive" state. The patch series follows
> instructions outlined here[1].
> 
> Obviously, the wrappers will be integrated in type-specific functions
> later on.
> 
> No behavioral change as of yet.
> 
> [1]: https://lore.kernel.org/all/aqI6v-_dc2DDSbgB@dread/
> 
> Jeffin Philip (2):
>   xfs: add lockref and generic helpers for refcounting
>   xfs: change xfs_trans_ail_delete return type to bool

It's great to see you starting on this, but there's not much point
in just posting wrappers that aren't used by anything. Until there
is code that uses them, we can't really say anythign useful about
the wrappers. e.g.

Is the API optimal? Don't know.

Is open coding the init correct for the generic case or is that just
projecting an antipattern from the BLI reference counting? Don't
know.

And so on. Hence it's best to present the wrappers with the code
that then uses them so we have the necessary context with which to
review them.

Cheers,

Dave.

-- 
Dave Chinner
dgc@xxxxxxxxxx