Re: [PATCH] net: phy: micrel: Advance register data pointer in write loop
From: Andrew Lunn
Date: Wed Sep 16 2026 - 19:42:36 EST
On Wed, Sep 16, 2026 at 07:19:28PM -0400, Abhishek Ojha wrote:
> lanphy_write_reg_data() does not advance the data pointer while iterating
> over the register table. As a result, it writes the first entry num times
> and leaves the remaining errata registers unconfigured.
>
> Single-entry tables are unaffected, but tables with multiple entries
> leave every entry after the first unapplied.
>
> Advance the data pointer after each successful write so every table entry
> is applied in order.
>
> Fixes: c8732e933925 ("net: phy: micrel: lan8842 errata")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Abhishek Ojha <abhishek.ojha@xxxxxxxxxxxxxxxxxxxx>
Makes you wounder if the short_center_tap errata has any value.
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew