Re: [PATCH net-next v5 4/4] selftests: net: test AF_PACKET multicast dumps
From: Jakub Kicinski
Date: Wed Sep 16 2026 - 21:54:22 EST
On Mon, 14 Sep 2026 10:45:39 +0900 Yuyang Huang wrote:
> + try:
> + addresses = rtnl.getmulticast(
> + {"ifa-family": socket.AF_PACKET, "ifa-index": dev_idx},
> + dump=True)
> + except NlError as e:
> + if e.error == errno.EOPNOTSUPP:
> + raise KsftSkipEx(
> + "kernel does not support AF_PACKET multicast dump")
What's the point of catching this exception?
The error for ENOPNOTSUPP will be both very rare (not sure I understand
where you expect it to come from TBH), and also about as meaningful as
the skip. Just let the exception propagate, it's fine.
Otherwise Pylint complains:
W0707: Consider explicitly re-raising using 'raise KsftSkipEx('kernel does not support AF_PACKET multicast dump') from e' (raise-missing-from)
> + raise