Re: [PATCH] iio: accel: mma9551: disable autosuspend on remove

[Jonathan Cameron]

On Mon, 14 Sep 2026 14:50:21 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Mon, 14 Sep 2026 19:24:47 +0800
> Guangshuo Li <lgs201920130244@xxxxxxxxx> wrote:
> 
> > mma9551_probe() enables runtime PM autosuspend with
> > pm_runtime_use_autosuspend(). The probe error path correctly undoes
> > this setting with pm_runtime_dont_use_autosuspend(), but the normal
> > remove path only disables runtime PM.
> > 
> > The runtime PM API requires pm_runtime_use_autosuspend() to be undone
> > with pm_runtime_dont_use_autosuspend() at driver exit unless runtime PM
> > was enabled with devm_pm_runtime_enable(). Leaving the autosuspend flag
> > set therefore leaves the runtime PM state incompletely cleaned up after
> > the driver is unbound.
> > 
> > Add the missing pm_runtime_dont_use_autosuspend() call to the remove
> > path.
> > 
> > This issue was found by manual code inspection.
> > 
> > Fixes: 6da93a6710a3 ("iio: accel: mma9551: Add runtime pm support")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> > ---
> >  drivers/iio/accel/mma9551.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c
> > index 7e01427fd9c4..182f488edab1 100644
> > --- a/drivers/iio/accel/mma9551.c
> > +++ b/drivers/iio/accel/mma9551.c
> > @@ -500,6 +500,7 @@ static void mma9551_remove(struct i2c_client *client)
> >  
> >  	iio_device_unregister(indio_dev);
> >  
> > +	pm_runtime_dont_use_autosuspend(&client->dev);
> >  	pm_runtime_disable(&client->dev);
> >  	pm_runtime_set_suspended(&client->dev);
> >    
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
Applied thanks.  Most of these drivers (maybe all) would benefit from
a sprinkling of devm_ magic if anyone has time to do it!

Jonathan

>