Re: [PATCH v3 0/4] Fix HugeTLB subpool used_hpages tracking
From: Andrew Morton
Date: Wed Sep 16 2026 - 23:13:21 EST
On Wed, 16 Sep 2026 16:39:00 -0700 Ackerley Tng via B4 Relay <devnull+ackerleytng.google.com@xxxxxxxxxx> wrote:
> HugeTLB subpools currently only track used pages (used_hpages) when a
> maximum size limit (max_hpages) is configured on the mount.
>
> ...
>
> This series addresses three problem areas resulting from untracked usage
> and asymmetric error handling:
These are rather serious-sounding problems.
I'm seeing Fixes: for 10-year-old patches, for one last year and one
this year. The fourth patch doesn't identify what to fix.
So if downstream people (-stable maintainers, others) follow our
recommendations, some kernels will get two of these patches, other
kernel versions will get three and some lucky kernels might get all
four. Are you confident that the patches can be split apart in this
fashion and still produce a good result? After all, we're sending
downstream some patch combinations which we didn't test.
Also, can you speculate about why these things took so long to
discover?
Ho hum, complicated. Let's at least slap a Fixes: on [4/4]. My
trillion-dollar sidekick suggests a9e443086489 ("hugetlb: disable
region_add file_region coalescing").
Our other little friend is talking to us:
https://sashiko.dev/#/patchset/20260916-hugetlb-subpool-always-track-used-v3-0-38aae9b5ccdd@xxxxxxxxxx
I'd like to queue this up promptly because it fixes things. But let's
seek additional review input and argue with Sashiko before taking that
step.