Re: [PATCH] nvme: work around -Wformat-security warning
From: Damien Le Moal
Date: Wed Sep 16 2026 - 23:41:09 EST
On 2026/09/16 18:44, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Passing a string variable into dev_set_name() causes a warning
> when building with -Wformat-security enabled:
>
> drivers/nvme/host/core.c: In function 'nvme_cdev_add':
> drivers/nvme/host/core.c:3911:9: error: format not a string literal and no format arguments [-Werror=format-security]
> 3911 | ret = dev_set_name(cdev_device, name);
>
> Remove the temporary strings and let dev_set_name() do the
> same thing internally.
>
> Fixes: 26acdaa357cd ("nvme: fix crash and memory leak during invalid cdev teardown")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
--
Damien Le Moal
Western Digital Research