Re: [PATCH v3 0/9] efi/libstub: Avoid UTF-16 conversion busywork
From: Ard Biesheuvel
Date: Thu Sep 17 2026 - 05:51:16 EST
On Thu, 17 Sep 2026, at 08:21, Vincent Mailhol wrote:
> On 16/09/2026 at 16:46, Ard Biesheuvel wrote:
>> From: Ard Biesheuvel <ardb@xxxxxxxxxx>
>>
>> The EFI libstub performs some redundant conversions between UTF-16 and
>> UTF-8 and back again, which includes dealing with surrogate pairs, which
>> UEFI implementations themselves simply ignore.
>>
>> So drop all the homegrown code, and use the existing UCS-2 (== UTF-16
>> without surrogate pairs) library code where conversion to UTF-8 is
>> actually needed (the kernel command line).
>>
>> The remaining handling involves the EFI console, which supports wide
>> characters natively, so just use those directly.
>
> This v3 looks good to me and runs fine.
>
> Patch 8 still uses spaces instead of tabulation for indentations. But,
> notwithstanding of that and for the full series:
>
> Reviewed-by: Vincent Mailhol <mailhol@xxxxxxxxxx>
>
Thanks. I've fixed patch #8 and pushed the set (minus the x86 boot)
to the bootloader-info topic branch. I'll merge that into efi/next
once the x86 changes land in tip.