Re: [PATCH net-next v8 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt
From: Krzysztof Kozlowski
Date: Thu Sep 17 2026 - 06:08:18 EST
On Tue, Sep 15, 2026 at 10:06:03AM +0200, Arthur Crepin Leblond wrote:
> Add an optional link status interrupt which can be connected to the
> LINKLED pin on the device to detect link status changes. This second
> interrupt is only supported on wiznet,w5500.
>
> Signed-off-by: Arthur Crepin Leblond <arthur@xxxxxxxxxxxxx>
> ---
> v8:
> - Remove Krzysztof Kozlowski reviewed-by tag after Sashiko review
> changes
> - Make the interrupts property conditional
>
> v7:
> - No changes
>
> v6:
> - Fix DT error: use minItems
> - Remove conditional properties
>
> v5:
> - Make the DT interrupts property dynamic from the compatible one
> - Fix DT bindings errors
>
> v4:
> - Update interrupts in DT bindings
>
> v3:
> - Fix DT binding errors
>
> v2:
> - Convert device tree binding to YAML
> ---
> .../devicetree/bindings/net/wiznet,w5100.yaml | 38 ++++++++++++++++++----
> 1 file changed, 31 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> index 25098308eb6e..da03f4e07f29 100644
> --- a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> @@ -12,10 +12,6 @@ maintainers:
> description: |
> This is a standalone 10/100 MBit Ethernet controller with SPI interface.
>
> -allOf:
> - - $ref: /schemas/net/ethernet-controller.yaml#
> - - $ref: /schemas/spi/spi-peripheral-props.yaml#
> -
> properties:
> compatible:
> enum:
> @@ -24,8 +20,11 @@ properties:
> - wiznet,w5500
>
> interrupts:
> - maxItems: 1
Broadest constraints always stay here.
I already asked for proper syntax here:
https://lore.kernel.org/all/688f57cd-a098-4904-b8cd-965470a89386@xxxxxxxxxx/
https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L127
Best regards,
Krzysztof