Re: [PATCH v3 1/3] pps: clients: gpio: propagate probe error codes

From: Bartosz Golaszewski

Date: Thu Sep 17 2026 - 06:09:10 EST


On Thu, 17 Sep 2026 09:56:09 +0200, Eliav Farber <farbere@xxxxxxxxxx> said:
> On the two probe error paths that map and request the interrupt, probe
> overwrote the error from gpiod_to_irq() and request_threaded_irq() with a
> hardcoded -EINVAL, hiding meaningful codes such as -EBUSY, -ENOMEM or
> -EPROBE_DEFER from the caller. The request_threaded_irq() failure message
> also logged the IRQ number but not the errno.
>
> Return the actual error code from both paths, and add the errno to the
> request_threaded_irq() failure message.
>
> Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
> ---

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>