Re: [PATCH 1/6] dt-bindings: media: Add bindings for qcom,nord-camss

[Krzysztof Kozlowski]

On Tue, Sep 15, 2026 at 05:34:11PM +0800, Wenmeng Liu wrote:
> Add bindings for the camera subsystem (CAMSS) on the Qualcomm Nord
> platform.
> 
> The Nord platform provides:
> - 3 x TPG (Test Pattern Generator)
> - 3 x CSID (CSI Decoder)
> - 10 x CSID Lite
> - 3 x VFE (Video Front End)
> - 10 x VFE Lite
> 
> Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/media/qcom,nord-camss.yaml | 393 +++++++++++++++++++++
>  1 file changed, 393 insertions(+)

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

...

> +        description:
> +          Input port for receiving CSI data.
> +
> +        properties:
> +          endpoint:
> +            $ref: video-interfaces.yaml#
> +            unevaluatedProperties: false
> +
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +              bus-type:
> +                enum:
> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
> +
> +            required:
> +              - data-lanes
> +

Missing supplies, altough maybe this is related to some other ongoing
work, so would be useful to see explanation in commit msg.

Best regards,
Krzysztof