Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add Xiaomi Mi 8 family compatibles

[David Heidelberg]

On 17/09/2026 12:21, Krzysztof Kozlowski wrote:
> On Tue, Sep 15, 2026 at 04:32:24PM +0200, David Heidelberg wrote:
> > +      - description: Xiaomi Mi 8 family
> > +        items:
> > +          - enum:
> > +              - xiaomi,dipper
> > +              - xiaomi,equuleus
> > +              - xiaomi,ursa
> > +          - const: xiaomi,dipper-common
>
> We do not make "common" compatibles.
> git grep common -- Documentation/devicetree/bindings/arm/qcom.yaml

TBH I have mental issue with calling it xiaomi,dipper-dipper

All three devices are branded as own devices, just based on 99.9% same base.

I'm not aware of any internal name which group these devices.

I could call it like xiaomi,common, but there is the polaris and beryllium, 
which aren't "that common" with these three.

Do you have idea what to do in this situation?

David

> See other examples how this can be named, even one below:
>
> > +          - const: qcom,sdm845
> > +
> >         - description: Xiaomi Poco F1
> >           items:
> >             - enum:
> >                 - xiaomi,beryllium-ebbg
> >                 - xiaomi,beryllium-tianma
> >             - const: xiaomi,beryllium
> >             - const: qcom,sdm845
>
> Best regards,
> Krzysztof