Re: [PATCH] net: ipa: Fix valid_state leak in ipa_smp2p_init()
From: Greg KH
Date: Thu Sep 17 2026 - 08:36:19 EST
On Thu, Sep 17, 2026 at 11:54:24AM +0000, Wentao Liang wrote:
> qcom_smem_state_get() takes a reference on the state, but
> ipa_smp2p_init() returns without releasing the "ipa-clock-enabled-valid"
> state when the bit number is out of range, when the "ipa-clock-enabled"
> state cannot be acquired or its bit number is out of range, when the
> smp2p structure cannot be allocated, and on the error paths that free
> the structure. Release the reference on all of these paths.
>
> Fixes: 530f9216a953 ("soc: qcom: ipa: AP/modem communications")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> ---
> drivers/net/ipa/ipa_smp2p.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
Did you forget the Assisted-by: tag?
Please reply to all of your sent patches and fix that up with new
versions.
thanks,
greg k-h