Re: [PATCH v18 2/5] phy: core: Add phy_get_by_of_node()

[Bryan O'Donoghue]

On 17/09/2026 13:29, Neil Armstrong wrote:
> >   /**
> >    * _of_phy_get() - lookup and obtain a reference to a phy by phandle
> >    * @np: device_node for which to get the phy
> >    * @index: the index of the phy
> >    *
> > - * Returns the phy associated with the given phandle value,
> > - * after getting a refcount to it or -ENODEV if there is no such phy or
> > - * -EPROBE_DEFER if there is a phandle to the phy, but the device is
> > - * not yet loaded. This function uses of_xlate call back function 
> > provided
> > - * while registering the phy_provider to find the phy instance.
> > + * Returns the phy associated with the given phandle value after getting
> > + * a refcount to it; -ENODEV if there is no such phy or the phy is
> > + * disabled; -EPROBE_DEFER if the phy provider is not yet available.
> >    */
>
> Why changing the comment here ? You're not supposed to changes the 
> _of_phy_get() behaviour.

I have no real memory of that change probably seemd like a good idea at 
the time.

Will drop

---
bod