RE: [PATCH 06/10] dt-bindings: clock: Add r8a774a3 CPG Core Clock definitions

[Ayman Chaudhry]

Hi Geert,

Thanks for your review!

> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Friday, September 4, 2026 4:13 PM
> To: Ayman Chaudhry <ayman.chaudhry.kc@xxxxxxxxxxx>
> Cc: magnus.damm <magnus.damm@xxxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Stephen Boyd <sboyd@xxxxxxxxxx>; Brian Masney
> <bmasney+clk@xxxxxxxxxx>; Jerome Brunet <jbrunet+clk@xxxxxxxxxxxx>;
> Ulf Hansson <ulfh@xxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> clk@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; Chris Paterson
> <Chris.Paterson2@xxxxxxxxxxx>; Biju Das <biju.das.jz@xxxxxxxxxxxxxx>;
> Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH 06/10] dt-bindings: clock: Add r8a774a3 CPG Core Clock
> definitions
> 
> Hi Ayman,
> 
> On Fri, 21 Aug 2026 at 17:05, Ayman Chaudhry
> <ayman.chaudhry.kc@xxxxxxxxxxx> wrote:
> > Add all the Renesas RZ/G2M v3.0 (a.k.a. R8A774A3) SoC Clock Pulse
> > Generator Core Clock Outputs, as listed in Table 11.3 ("List of Clocks
> > [RZ/G2M V1.3, RZ/G2M V3.0]") of the RZ/G2 Hardware User's Manual.
> >
> > Signed-off-by: Ayman Chaudhry <ayman.chaudhry.kc@xxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/r8a774a3-cpg-mssr.h
> 
> Missing "renesas," vendor prefix.

Agreed, I will rename this in v2.

> 
> > @@ -0,0 +1,59 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > +/*
> > + * Copyright (C) 2026 Renesas Electronics Corp.
> > + */
> > +#ifndef __DT_BINDINGS_CLOCK_R8A774A3_CPG_MSSR_H__
> > +#define __DT_BINDINGS_CLOCK_R8A774A3_CPG_MSSR_H__
> 
> Missing "RENESAS_" vendor prefix.

Agreed, I will add this in v2.

Kind Regards,
Ayman

> 
> For the contents:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds