RE: [PATCH 03/10] pmdomain: renesas: rcar-sys: Add r8a774a3 support

[Ayman Chaudhry]

Hi Geert,

Thanks for the review!

> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Friday, September 4, 2026 4:03 PM
> To: Ayman Chaudhry <ayman.chaudhry.kc@xxxxxxxxxxx>
> Cc: magnus.damm <magnus.damm@xxxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Stephen Boyd <sboyd@xxxxxxxxxx>; Brian Masney
> <bmasney+clk@xxxxxxxxxx>; Jerome Brunet <jbrunet+clk@xxxxxxxxxxxx>;
> Ulf Hansson <ulfh@xxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> clk@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; Chris Paterson
> <Chris.Paterson2@xxxxxxxxxxx>; Biju Das <biju.das.jz@xxxxxxxxxxxxxx>;
> Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH 03/10] pmdomain: renesas: rcar-sys: Add r8a774a3
> support
> 
> Hi Ayman,
> 
> On Fri, 21 Aug 2026 at 17:05, Ayman Chaudhry
> <ayman.chaudhry.kc@xxxxxxxxxxx> wrote:
> > Add support for Renesas RZ/G2M v3.0 (a.k.a. R8A774A3) SoC power areas
> > to the R-Car SYSC driver. The RZ/G2M v3.0 SYSC is similar to the
> > RZ/G2M
> > v1.3 SYSC, however it lacks the A2VC0 power area.
> >
> > Signed-off-by: Ayman Chaudhry <ayman.chaudhry.kc@xxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/drivers/pmdomain/renesas/r8a774a3-sysc.c
> > @@ -0,0 +1,45 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Renesas RZ/G2M v3.0 System Controller
> > + * Copyright (C) 2026 Renesas Electronics Corp.
> > + *
> > + * Based on Renesas R-Car M3-W System Controller
> > + * Copyright (C) 2016 Glider bvba
> > + */
> > +
> > +#include <linux/kernel.h>
> > +
> > +#include <dt-bindings/power/r8a774a3-sysc.h>
> > +
> > +#include "rcar-sysc.h"
> > +
> > +static const struct rcar_sysc_area r8a774a3_areas[] __initconst = {
> > +       { "always-on",     0, 0, R8A774A3_PD_ALWAYS_ON, -1,
> PD_ALWAYS_ON },
> > +       { "ca57-scu",  0x1c0, 0, R8A774A3_PD_CA57_SCU,
> R8A774A3_PD_ALWAYS_ON,
> > +         PD_SCU },
> > +       { "ca57-cpu0",  0x80, 0, R8A774A3_PD_CA57_CPU0,
> R8A774A3_PD_CA57_SCU,
> > +         PD_CPU_NOCR },
> > +       { "ca57-cpu1",  0x80, 1, R8A774A3_PD_CA57_CPU1,
> R8A774A3_PD_CA57_SCU,
> > +         PD_CPU_NOCR},
> 
> Please add a space before the closing curly brace.

Thanks for catching this, I will fix it in v2.

Kind Regards,
Ayman

> 
> > +       { "ca53-scu",  0x140, 0, R8A774A3_PD_CA53_SCU,
> R8A774A3_PD_ALWAYS_ON,
> > +         PD_SCU },
> > +       { "ca53-cpu0", 0x200, 0, R8A774A3_PD_CA53_CPU0,
> R8A774A3_PD_CA53_SCU,
> > +         PD_CPU_NOCR },
> > +       { "ca53-cpu1", 0x200, 1, R8A774A3_PD_CA53_CPU1,
> R8A774A3_PD_CA53_SCU,
> > +         PD_CPU_NOCR },
> > +       { "ca53-cpu2", 0x200, 2, R8A774A3_PD_CA53_CPU2,
> R8A774A3_PD_CA53_SCU,
> > +         PD_CPU_NOCR },
> > +       { "ca53-cpu3", 0x200, 3, R8A774A3_PD_CA53_CPU3,
> R8A774A3_PD_CA53_SCU,
> > +         PD_CPU_NOCR },
> > +       { "a3vc",      0x380, 0, R8A774A3_PD_A3VC,
> R8A774A3_PD_ALWAYS_ON },
> > +       { "a2vc1",     0x3c0, 1, R8A774A3_PD_A2VC1, R8A774A3_PD_A3VC },
> > +       { "3dg-a",     0x100, 0, R8A774A3_PD_3DG_A,
> R8A774A3_PD_ALWAYS_ON },
> > +       { "3dg-b",     0x100, 1, R8A774A3_PD_3DG_B, R8A774A3_PD_3DG_A },
> > +};
> 
> For the content:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds